`StateBuilder::with_background_transition_merge` appears to do nothing

bluealloy / revm

Rust implementation of the Ethereum Virtual Machine.

https://bluealloy.github.io/revm/

MIT License

1.59k stars 518 forks source link

`StateBuilder::with_background_transition_merge` appears to do nothing #1708

Open prestwich opened 3 weeks ago

prestwich commented 3 weeks ago

https://github.com/bluealloy/revm/blob/1ad860469755e3cf71383f45d71c3faaf61d3029/crates/revm/src/db/states/state_builder.rs#L28

the option is documented as starting a thread, but it appears that never happens. am i missing something?

rakita commented 2 weeks ago

It looks like a leftover, the idea was to do some processing in the background task, but after measuring the time spent in there gains would be small.