search

bluealloy / revm

Rust implementation of the Ethereum Virtual Machine.
https://bluealloy.github.io/revm/
MIT License
1.59k stars 518 forks source link

Use TestAuthorization and skip decoding of eip7702 tx #1728

Open rakita opened 2 weeks ago

rakita commented 2 weeks ago

In this PR we have decoded tx bytes to extract AuthorizationList.

a better way would be to use values from json as we are already parsing them, it is needed to cast them to RecoveredAuthorization and test/debug this.

royvardhan commented 1 week ago

Hi @rakita I am down to attempt this but have some questions:

  1. I can read these tests at alloy-rs/eips, would you like me to extend it with extracting values directly from json and then assert them?
  2. Or would you like to add new tests in blue-alloy/revm where we parse values from json and test them?
royvardhan commented 1 week ago

@rakita Awaiting your inputs, thanks!

rakita commented 1 week ago

We should remove this file: https://github.com/bluealloy/revm/blob/main/bins/revme/src/cmd/statetest/models/eip7702.rs And use this struck: https://github.com/bluealloy/revm/blob/d38ff452714e1c4a17cf0fbdaa4913f6d61033c4/bins/revme/src/cmd/statetest/models/mod.rs#L139