search

blueapron / kafka-connect-protobuf-converter

Protobuf converter plugin for Kafka Connect
Other
95 stars 53 forks source link

Update the naming functionality #24

Closed sschatts closed 5 years ago

sschatts commented 5 years ago

Description

This completes the feature of having the name at the schema level and updates the tests associated with this new feature.

This updates how the name is returned from the descriptor (com.google.protobuf.Descriptors.FieldDescriptor) to match how the name is returned from the message (com.google.protobuf.Descriptors.Descriptor).

Related Documentation

Message - https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/Message Descriptor.Descriptor - https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/Descriptors.Descriptor Descriptor.FieldDescriptor - https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/Descriptors.FieldDescriptor

Background

Couldn't package 2.1.0 to Maven Central because mvn test had failures. This PR extends the naming functionality to properly update the tests.

Related

https://github.com/blueapron/kafka-connect-protobuf-converter/pull/20

sschatts commented 5 years ago

@smithakoduri and/or @criccomini can you confirm this is the behavior you expect?

smithakoduri commented 5 years ago

@sschatts: Yes, this is the behavior we are expecting.