search

bluebanquise / bluebanquise

A coherent Ansible roles collection to simply deploy clusters of nodes.
https://bluebanquise.com
MIT License
110 stars 50 forks source link

BB-38 - [BUG] systemd service file, prometheus.service, should be set to 0644 instead of 0755 #950

Open sgaosdgr opened 1 month ago

sgaosdgr commented 1 month ago

In https://github.com/bluebanquise/bluebanquise/blob/master/collections/monitoring/roles/prometheus/tasks/server_prometheus.yml, the permission for /etc/systemd/system/prometheus.service is currently set to 0755. For a systemd service file, the permission should be 0644

Context

The permission for /etc/systemd/system/prometheus.service is currently set to 0755. It triggers warnings by systemd. The right permission should be 0644.

Process

Apply role prometheus. Check permission on /etc/systemd/system/prometheus.service.

Expected result

The expected permission should be 0644.

Current result

0755

Possible Fix

Change line 30 to: mode: 0644

Additional data

Tested on RockyLinux 9 x86_64.

sgaosdgr commented 1 month ago

Same issue in https://github.com/bluebanquise/bluebanquise/blob/master/collections/monitoring/roles/prometheus/tasks/client.yml line 42

oxedions commented 1 month ago

Dear @sgaosdgr

Thank you for notifying this bug :blush: Let me fix that :wink:

oxedions commented 1 month ago

Done ! :smiley: