search

bluebird75 / luaunit

LuaUnit is a popular unit-testing framework for Lua, with an interface typical of xUnit libraries (Python unittest, Junit, NUnit, ...). It supports several output formats (Text, TAP, JUnit, ...) to be used directly or work with Continuous Integration platforms (Jenkins, Maven, ...).
Other
565 stars 136 forks source link

Add support for all error() argument types #113

Closed utkinn closed 6 years ago

utkinn commented 6 years ago

Fix bluebird75/luaunit#106. luaunit crashes when error() called with a non-string argument, I fixed this.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.0005%) to 99.632% when pulling af14d5bb8eee53271941a3b043b26be02083b391 on javabird25:master into 6e9bf7b79dcdfd50a5dda64c3bad5a1f051c8a3f on bluebird75:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.07%) to 99.636% when pulling 2f018b6e1304350f7cdc29417656ba8b179fed0c on javabird25:master into 00d145c1c2b78bf9cff80a8ac66ca72c0d5446f6 on bluebird75:master.

bluebird75 commented 6 years ago

Thanks for the proposal. Please also add some test cases for this.

bluebird75 commented 6 years ago

Sorry for the long time without response. Your PR contains a lot of changes related to whitespace at the end of the lines (probably your editor settings). While this could be an interesting style fix, I don't want to have it in this PR as it is creating noise which makes finding the real changes difficult.

Regarding your test, could you add a verification of the error message content ?

Thanks in advance.

utkinn commented 6 years ago

I guess it's done.

Travis seems to experience some problems not related to this request on some enviroments.

bluebird75 commented 6 years ago

Indeed. Thanks for the contribution and thanks for your patience.

bluebird75 commented 6 years ago

Out of curiosity, what are you using luaunit for ?

utkinn commented 6 years ago

Currently for nothing. I planned using it for testing addons for Garry's Mod but I'm still trying to figure out how to adapt LuaUnit for it.