bluebird75 / luaunit

LuaUnit is a popular unit-testing framework for Lua, with an interface typical of xUnit libraries (Python unittest, Junit, NUnit, ...). It supports several output formats (Text, TAP, JUnit, ...) to be used directly or work with Continuous Integration platforms (Jenkins, Maven, ...).
Other
572 stars 137 forks source link

Lua 5.4 compatibility #135

Closed mna closed 3 years ago

mna commented 3 years ago

Hello,

As far as I can tell from testing it on one of my projects, luaunit works fine on Lua 5.4. This change would make it possible to install with that version (if merged, this change should be published on luarocks, of course). Of course, LuaUnit's tests themselves pass fine with Lua 5.4.1 that I have on my system (Linux Fedora).

Thanks, Martin

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.2%) to 98.294% when pulling a1a2d2097a8b8dcd20035ac8b27d4ed8fc33edd3 on mna:patch-1 into d992a6035fd085cee795357430c7d3dac73c5a7f on bluebird75:master.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.2%) to 98.294% when pulling a1a2d2097a8b8dcd20035ac8b27d4ed8fc33edd3 on mna:patch-1 into d992a6035fd085cee795357430c7d3dac73c5a7f on bluebird75:master.

bluebird75 commented 3 years ago

I have setup successfully lua 5.4 on travis-ci successfully. So yes, this is good.

I just need to actually do another release to have this officially propagated.

mna commented 3 years ago

Génial, merci!