linuxmaniac
commented
2 years ago Closed linuxmaniac closed 2 years ago
linuxmaniac
commented
2 years ago 
bluebird75
commented
2 years ago I'll investigate but that's really strange...
seabass-labrax
commented
2 years ago I too can reproduce the issue when trying to run the tests. The error is blocking my Debian packaging of the Fennel programming language, which needs luaunit v3.4 rather than the existing version in Debian, v3.3.
I've spent a weekend trying to debug this, but unfortunately to no avail. The best guess I have so far is that there is a difference between running luaunit functions directly (where they all seem to work) and running them from a constructed luaunit instance (where many fail, seemingly out of scope - maybe having not been declared as public?)
As I wrote to @linuxmaniac earlier:
Using the function TestLuaUnitExecution:test_callSkipIfFromTest as example:
...
Changing runner:setOutputType( "NIL" ) to runner:setOutputType('text') outputs the errors from that specific test rather than the overarching tests.
This leads to the error message:
1) my_test_skip ./test/test_luaunit.lua:3887: attempt to call field 'skipIf' (a nil value) stack traceback: [C]: in function 'xpcall'
Would really appreciate any help on this; thanks :smiley:
bluebird75
commented
2 years ago Totally forgot about this. I'll look into it.
bluebird75
commented
2 years ago I remember now: I tested it on the CI, on a local ubuntu, and on a gentoo. Not reproducible. Then I forgot about it.
I'll stick to it this time until I find the problem and solution.
seabass-labrax
commented
2 years ago Thank you so much for your time and effort, @bluebird75! It's really appreciated :grinning:
bluebird75
commented
2 years ago Tested also in bullseye debian in Windows Subsytem for Linux, not reproducible.
I think I'll need a system where I can reproduce this. Can you guys lend me a ssh account for testing ?
linuxmaniac
commented
2 years ago Preparation...
$ git clone https://salsa.debian.org/lua-team/lua-unit.git
Cloning into 'lua-unit'...
remote: Enumerating objects: 757, done.
remote: Counting objects: 100% (115/115), done.
remote: Compressing objects: 100% (75/75), done.
remote: Total 757 (delta 46), reused 80 (delta 35), pack-reused 642
Receiving objects: 100% (757/757), 2.02 MiB | 1.84 MiB/s, done.
Resolving deltas: 100% (401/401), done.
$ docker run -it --rm -v $(pwd)/lua-unit:/code:rw --name deb-sid debian:sid /bin/bash
root@06a29404d0d4:/# curl -LJ https://github.com/bluebird75/luaunit/releases/download/LUAUNIT_V3_4/luaunit-3.4.tar.gz --output lua-unit_3.4.orig.tar.gz
root@06a29404d0d4:/# cd /code
root@06a29404d0d4:/code# apt update && apt install debhelper-compat dh-lua --yesHow to reproduce inside docker
root@06a29404d0d4:/code# dpkg-buildpackage
dpkg-buildpackage: info: source package lua-unit
dpkg-buildpackage: info: source version 3.4-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Victor Seva <vseva@debian.org>
dpkg-buildpackage: info: host architecture amd64
dpkg-source --before-build .
debian/rules clean
dh clean --buildsystem=lua --with lua
dh_auto_clean -O--buildsystem=lua
make --no-print-directory -f /usr/share/dh-lua/make/dh-lua.Makefile.multiple clean
Making target clean for debian/lua5.1.dh-lua.conf
# fix for leftovers of dh-lua < 14
Target clean made
Making target clean for debian/lua5.2.dh-lua.conf
# fix for leftovers of dh-lua < 14
Target clean made
Making target clean for debian/lua5.3.dh-lua.conf
# fix for leftovers of dh-lua < 14
Target clean made
Making target clean for debian/lua5.4.dh-lua.conf
# fix for leftovers of dh-lua < 14
Target clean made
dh_autoreconf_clean -O--buildsystem=lua
dh_clean -O--buildsystem=lua
dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building lua-unit using existing ./lua-unit_3.4.orig.tar.gz
dpkg-source: info: building lua-unit in lua-unit_3.4-1.debian.tar.xz
dpkg-source: info: building lua-unit in lua-unit_3.4-1.dsc
debian/rules build
dh build --buildsystem=lua --with lua
dh_update_autotools_config -O--buildsystem=lua
dh_autoreconf -O--buildsystem=lua
dh_auto_configure -O--buildsystem=lua
make --no-print-directory -f /usr/share/dh-lua/make/dh-lua.Makefile.multiple configure
Making target configure for debian/lua5.1.dh-lua.conf
# .install
Filling in debian/lua-unit.install using /usr/share/dh-lua/template/lib.install.in
Adding new line:
Adding new line: usr/share/lua/5.1/luaunit.lua
Filling in debian/lua-unit-dev.install using /usr/share/dh-lua/template/dev.install.in
Adding new line:
# lua_versions
Filling in debian/lua_versions
Adding new line: 5.1
Target configure made
Making target configure for debian/lua5.2.dh-lua.conf
# .install
Filling in debian/lua-unit.install using /usr/share/dh-lua/template/lib.install.in
Adding new line: usr/share/lua/5.2/luaunit.lua
Filling in debian/lua-unit-dev.install using /usr/share/dh-lua/template/dev.install.in
# lua_versions
Filling in debian/lua_versions
Adding new line: 5.2
Target configure made
Making target configure for debian/lua5.3.dh-lua.conf
# .install
Filling in debian/lua-unit.install using /usr/share/dh-lua/template/lib.install.in
Adding new line: usr/share/lua/5.3/luaunit.lua
Filling in debian/lua-unit-dev.install using /usr/share/dh-lua/template/dev.install.in
# lua_versions
Filling in debian/lua_versions
Adding new line: 5.3
Target configure made
Making target configure for debian/lua5.4.dh-lua.conf
# .install
Filling in debian/lua-unit.install using /usr/share/dh-lua/template/lib.install.in
Adding new line: usr/share/lua/5.4/luaunit.lua
Filling in debian/lua-unit-dev.install using /usr/share/dh-lua/template/dev.install.in
# lua_versions
Filling in debian/lua_versions
Adding new line: 5.4
Target configure made
dh_auto_build -O--buildsystem=lua
make --no-print-directory -f /usr/share/dh-lua/make/dh-lua.Makefile.multiple build
Making target build for debian/lua5.1.dh-lua.conf
Target build made
Making target build for debian/lua5.2.dh-lua.conf
Target build made
Making target build for debian/lua5.3.dh-lua.conf
Target build made
Making target build for debian/lua5.4.dh-lua.conf
Target build made
dh_auto_test -O--buildsystem=lua
make --no-print-directory -f /usr/share/dh-lua/make/dh-lua.Makefile.multiple test
Making target test for debian/lua5.1.dh-lua.conf
# tests
Copying luaunit.lua in /code/5.1-unit for test
****************** lua dynamic custom (5.1) ******
..............................................................................................F......F...............F...............................................F........................................
Failed tests:
-------------
1) TestLuaUnitExecution.testRunSomeTestByLocalInstance
./test/test_luaunit.lua:3227: expected: "MyLocalTestToto2:test2"
actual: "MyLocalTestFunction"
stack traceback:
./test/test_luaunit.lua:3227: in function 'TestLuaUnitExecution.testRunSomeTestByLocalInstance'
2) TestLuaUnitExecution.testRunSomeTestByGlobalInstance
./test/test_luaunit.lua:3205: expected: "Toto.test1"
actual: "Toto.testa"
stack traceback:
./test/test_luaunit.lua:3205: in function 'TestLuaUnitExecution.testRunSomeTestByGlobalInstance'
3) TestLuaUnitExecution.testRunSetupAndTeardown
./test/test_luaunit.lua:3303: expected: "1setUp"
actual: "2setUp"
stack traceback:
./test/test_luaunit.lua:3303: in function 'TestLuaUnitExecution.testRunSetupAndTeardown'
4) TestLuaUnitExecution.testWithSetupClass_TeardownClass
./test/test_luaunit.lua:3699: expected: "Atest2"
actual: "AteardownClass"
stack traceback:
./test/test_luaunit.lua:3699: in function 'TestLuaUnitExecution.testWithSetupClass_TeardownClass'
Ran 206 tests in 0.020 seconds, 202 successes, 4 failures
make[2]: *** [/usr/share/dh-lua/make/dh-lua.Makefile.single:315: test-lua-dynamic-real-custom] Error 4
make[1]: *** [/usr/share/dh-lua/make/dh-lua.Makefile.multiple:12: test] Error 1
dh_auto_test: error: make --no-print-directory -f /usr/share/dh-lua/make/dh-lua.Makefile.multiple test returned exit code 2
make: *** [debian/rules:4: build] Error 255
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2I'll try that. It will be my first time using docker so be patient if I don't get it right on the first attempt.
bluebird75
commented
2 years ago Ok, I am stuck in the middle of the preparation:
root@4b8b4e4d7086:/# curl -LJ https://github.com/bluebird75/luaunit/releases/download/LUAUNIT_V3_4/luaunit-3.4.tar.gz --output lua-unit_3.4.orig.tar.gz
bash: curl: command not foundI tried to install curl but I ran into other problems:
root@4b8b4e4d7086:/# apt install curl
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package curlI also got more problems in the setup of the container:
root@4b8b4e4d7086:/code# apt update && apt install debhelper-compat dh-lua --yes
Get:1 http://deb.debian.org/debian sid InRelease [165 kB]
Err:1 http://deb.debian.org/debian sid InRelease
The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 648ACFD622F3D138 NO_PUBKEY 0E98404D386FA1D9
root@4b8b4e4d7086:/code# apt-key adv --keyserver keyring.debian.org --recv-keys 648ACFD622F3D138
E: gnupg, gnupg2 and gnupg1 do not seem to be installed, but one of them is required for this operation
root@4b8b4e4d7086:/code# apt install gnupg
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Package gnupg is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
root@4b8b4e4d7086:/code# apt install gpg
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package gpglets try again...
Preparation:
git clone https://salsa.debian.org/lua-team/lua-unit.git
docker pull debian:sid
docker run -it --rm -v $(pwd)/lua-unit:/code:rw --name deb-sid debian:sid /bin/bashInside docker
root@f1e0f747f502:/# apt update && apt install curl debhelper-compat dh-lua --yes
root@f1e0f747f502:/# curl -LJ https://github.com/bluebird75/luaunit/releases/download/LUAUNIT_V3_4/luaunit-3.4.tar.gz --output lua-unit_3.4.orig.tar.gz
root@f1e0f747f502:/# cd /code
root@f1e0f747f502:/# dpkg-buildpackageNo issues of keys in my side, my debian:sid is, just pulled right now:
docker image inspect debian:sid| grep Id
"Id": "sha256:87282e1afcaa541525a5b5cbb6d701830687337051e351874802ce1eb7ea2f45",Yes, I repeated the process unsuccessfully
philippe@ordi-papa:~/work$ docker pull debian:sid
sid: Pulling from library/debian
Digest: sha256:dcf764fb40aa7a5b8b6ad088a307945ad647919f0c6a75d73b95d1b3149c7942
Status: Image is up to date for debian:sid
docker.io/library/debian:sid
philippe@ordi-papa:~/work$ docker run -it --rm -v $(pwd)/lua-unit:/code:rw --name deb-sid debian:sid /bin/bash
root@374d2942d67d:/# apt update && apt install curl debhelper-compat dh-lua --yes
Get:1 http://deb.debian.org/debian sid InRelease [165 kB]
Err:1 http://deb.debian.org/debian sid InRelease
The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 648ACFD622F3D138 NO_PUBKEY 0E98404D386FA1D9
Reading package lists... Done
W: http://deb.debian.org/debian/dists/sid/InRelease: The key(s) in the keyring /etc/apt/trusted.gpg.d/debian-archive-bullseye-automatic.gpg are ignored as the file is not readable by user '_apt' executing apt-key.
W: http://deb.debian.org/debian/dists/sid/InRelease: The key(s) in the keyring /etc/apt/trusted.gpg.d/debian-archive-bullseye-security-automatic.gpg are ignored as the file is not readable by user '_apt' executing apt-key.
W: http://deb.debian.org/debian/dists/sid/InRelease: The key(s) in the keyring /etc/apt/trusted.gpg.d/debian-archive-bullseye-stable.gpg are ignored as the file is not readable by user '_apt' executing apt-key.
W: http://deb.debian.org/debian/dists/sid/InRelease: The key(s) in the keyring /etc/apt/trusted.gpg.d/debian-archive-buster-automatic.gpg are ignored as the file is not readable by user '_apt' executing apt-key.
W: http://deb.debian.org/debian/dists/sid/InRelease: The key(s) in the keyring /etc/apt/trusted.gpg.d/debian-archive-buster-security-automatic.gpg are ignored as the file is not readable by user '_apt' executing apt-key.
W: http://deb.debian.org/debian/dists/sid/InRelease: The key(s) in the keyring /etc/apt/trusted.gpg.d/debian-archive-buster-stable.gpg are ignored as the file is not readable by user '_apt' executing apt-key.
W: http://deb.debian.org/debian/dists/sid/InRelease: The key(s) in the keyring /etc/apt/trusted.gpg.d/debian-archive-stretch-automatic.gpg are ignored as the file is not readable by user '_apt' executing apt-key.
W: http://deb.debian.org/debian/dists/sid/InRelease: The key(s) in the keyring /etc/apt/trusted.gpg.d/debian-archive-stretch-security-automatic.gpg are ignored as the file is not readable by user '_apt' executing apt-key.
W: http://deb.debian.org/debian/dists/sid/InRelease: The key(s) in the keyring /etc/apt/trusted.gpg.d/debian-archive-stretch-stable.gpg are ignored as the file is not readable by user '_apt' executing apt-key.
W: GPG error: http://deb.debian.org/debian sid InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 648ACFD622F3D138 NO_PUBKEY 0E98404D386FA1D9
E: The repository 'http://deb.debian.org/debian sid InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
root@374d2942d67d:/#For information, I am running docker inside WSL2 Debian stretch. Not sure if that helps.
seabass-labrax
commented
2 years ago @bluebird75, wow, that's really strange. I've never seen that error before. Debian stretch is going to go out of support next week, as it happens, so it might be worth updating the WSL2 image to see if that helps! If not, I think I might be able to provide a machine that you can SSH into to test this. :grinning:
Thanks again!
bluebird75
commented
2 years ago Honestly, a ssh will make me happy. I have already spent quite some time on this and I have not even reproduced it.
Please write to me privately to phil.fremy at free.fr
linuxmaniac
commented
2 years ago @bluebird75 I pushed an image with everything needed
commands outside docker:
/tmp/luaunit # git clone https://salsa.debian.org/lua-team/lua-unit.git
Cloning into 'lua-unit'...
remote: Enumerating objects: 757, done.
remote: Counting objects: 100% (115/115), done.
remote: Compressing objects: 100% (75/75), done.
remote: Total 757 (delta 46), reused 80 (delta 35), pack-reused 642
Receiving objects: 100% (757/757), 2.02 MiB | 1.99 MiB/s, done.
Resolving deltas: 100% (401/401), done.
/tmp/luaunit # docker pull linuxmaniac/luaunit:test
test: Pulling from linuxmaniac/luaunit
Digest: sha256:7c3f65e59d148bc9e485a07bd3faca663c8e105b3fb399bfd158462a65ce0257
Status: Image is up to date for linuxmaniac/luaunit:test
docker.io/linuxmaniac/luaunit:test
/tmp/luaunit # docker run -it --rm -v $(pwd)/lua-unit:/code:rw --name deb-sid linuxmaniac/luaunit:test /bin/bashcommands inside docker:
root@ad142f5a121e:/# curl -LJ https://github.com/bluebird75/luaunit/releases/download/LUAUNIT_V3_4/luaunit-3.4.tar.gz --output lua-unit_3.4.orig.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 289k 100 289k 0 0 348k 0 --:--:-- --:--:-- --:--:-- 3321k
root@ad142f5a121e:/# cd /code
root@ad142f5a121e:/code# dpkg-buildpackageI hope this will work for you
bluebird75
commented
2 years ago Ok, I finally reproduced it.
This is due to a bug when I released the v3.4 , where it was not possible to run the unit tests with shuffling on. I fixed it and since the release was only out for a few hours, I moved the tag. Bad practice ! You were quick to catch it.
So, if you sync your luaunit version with the current v3.4 tag, all should be fine.
linuxmaniac
commented
2 years ago That was tricky! Thanks!