search

bluebird75 / luaunit

LuaUnit is a popular unit-testing framework for Lua, with an interface typical of xUnit libraries (Python unittest, Junit, NUnit, ...). It supports several output formats (Text, TAP, JUnit, ...) to be used directly or work with Continuous Integration platforms (Jenkins, Maven, ...).
Other
572 stars 137 forks source link

Improve _is_table_equals() function and fix various errors #65

Closed n1tehawk closed 8 years ago

n1tehawk commented 8 years ago

This pull request incorporates a significant portion of the changes proposed in #57. Merging this would fix a number of actual errors (mostly related to table recursion), and should make it easier to examine - and possibly find a consensus on - the remaining changes.

@AlfonZ42 I'd especially like your feedback on this set of patches. Do you consider these useful in moving forward with your pull request?

n1tehawk commented 8 years ago

P.S.: I disliked the fact that the last patch was only adding test cases and most of its original commit message had become meaningless (as some issues were already addressed by previous changes). I've now squashed the two additional tests into the commit that actually fixes the recursion problem (1894f07).

bluebird75 commented 8 years ago

Patch looks good and non controversial to me. @AlfonZ42 looking forward to your feedback...

bluebird75 commented 8 years ago

no feedback ... let's merge !