blueboxgroup / ursula

Ansible playbooks for operating OpenStack - Powering Blue Box Cloud.
https://www.blueboxcloud.com
204 stars 5 forks source link

Let cloud_admin do live migration #2815

Closed yiheqilin closed 7 years ago

yiheqilin commented 7 years ago

edit keystone policy.json to show Admin/instances in horizon to cloud_admin edit nova policy.json to let cloud_admin trigger live migration

@Xiaohua-Shen Could you review this PR ?

bbc-jenkins commented 7 years ago

Can one of the admins verify this patch?

bbc-jenkins commented 7 years ago

Can one of the admins verify this patch?

bbc-jenkins commented 7 years ago

Can one of the admins verify this patch?

Xiaohua-Shen commented 7 years ago

LGTM

Xiaohua-Shen commented 7 years ago

@lihkin213 the reason for admin_required_limit is: In horizon, live migration action is under menu of admin->instance->live migration action. and dashboard to show admin->instance need privilege of 'admin_required' (that's hardcoded in dashboard). Now cloud_admin has no privilege to show this panel.

So if we keep 'admin_required' unchanged and add 'cloud_admin' to this rule, then cloud_admin can see the panel , but also has all keystone related CRUD privilege.

What we tried to do is: let cloud_admin can see this panel: admin->instance->live migration action, and still has no other keystone privilege.

lihkin213 commented 7 years ago

We should see if we can use horizon customization for this instead of modifying the policy file

yiheqilin commented 7 years ago

Base on previous reviews, edit nova policy only

Xiaohua-Shen commented 7 years ago

@lihkin213 verified on integration test env and it works.

nirajdp76 commented 7 years ago

ok to test

nirajdp76 commented 7 years ago

@lihkin213 can u provide your approval

lihkin213 commented 7 years ago

retest

lihkin213 commented 7 years ago

ok to test

Xiaohua-Shen commented 7 years ago

retest