Closed yiheqilin closed 7 years ago
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
LGTM
@lihkin213 the reason for admin_required_limit is: In horizon, live migration action is under menu of admin->instance->live migration action. and dashboard to show admin->instance need privilege of 'admin_required' (that's hardcoded in dashboard). Now cloud_admin has no privilege to show this panel.
So if we keep 'admin_required' unchanged and add 'cloud_admin' to this rule, then cloud_admin can see the panel , but also has all keystone related CRUD privilege.
What we tried to do is: let cloud_admin can see this panel: admin->instance->live migration action, and still has no other keystone privilege.
We should see if we can use horizon customization for this instead of modifying the policy file
Base on previous reviews, edit nova policy only
@lihkin213 verified on integration test env and it works.
ok to test
@lihkin213 can u provide your approval
retest
ok to test
retest
edit keystone policy.json to show Admin/instances in horizon to cloud_admin edit nova policy.json to let cloud_admin trigger live migration
@Xiaohua-Shen Could you review this PR ?