search

blueboy / portal

This portal repo is for development purposes only
http://github.com/blueboy/portal
GNU General Public License v2.0
27 stars 24 forks source link

[bug] priest fade does not account for spell cooldown #33

Closed kennumen closed 11 years ago

kennumen commented 11 years ago

was testing, priest kept getting aggro and spamming 'casting fade' every tick.

1) check and make sure it's not a chat glitch and that he's actually casting fade rather than just saying he does yet going his merry own way 2) see if cooldown check can't be added to PlayerbotAI::CastSpell (assuming (1) holds true).

kennumen commented 11 years ago

Additional info: it looks like it's trying to cast fade but failing to see a failed casting. Obviously it's during combat so I'm rarely paying attention (let alone paying close attention) but from what I can tell the priest screams it out a lot but doesn't actually get fade all that often (as a buff seen from its party members aka me).

kennumen commented 11 years ago

Fade was being cast properly. However, if it failed (no mana, cooldown, ...) it ignored it and spammed its FADE message and returned RETURN_CONTINUE. Fixed that and twaeked a few other 'panic mode' priest snippets.

Not entirely convinced DPS code works properly but since nobody's complained on that, screw it. Too tired and a day like today... Either someone will complain or I will be unable to let it go after all :) (in other words - another issue if it's an issue at all)