search

blueboy / portal

This portal repo is for development purposes only
http://github.com/blueboy/portal
GNU General Public License v2.0
27 stars 24 forks source link

need vs greed #34

Open kennumen opened 12 years ago

kennumen commented 12 years ago

Integrate 'IsBetterEquip' [not actual function name] from Equip Auto into need vs greed roll (rather than 'can i equip it' which I believe is used now).

blueboy commented 11 years ago

This maybe more difficult than it seems. To do an item comparison as used with Equip Auto, you need a pointer (Item) for each item involved. We have a pointer for the equipped item, but not for the rolled item. We could change the parameters passed to the AutoEquipComparison() function (from Item to ItemPrototype), but this would require the code to be re-worked and I'm not sure whether it is worth it.

The roll dialog requires a spontaneous decision from players as to whether a rolled item is needed or not. It would be an unfair advantage for the bots to base their decision on a full item comparision, as used in Equip Auto. The current code determines whether the rolled item would be useful or not for a particular bot. I feel that this is sufficient to simulate a snap decision by the bots.

In my recent push, I have included a post roll (SMSG_LOOT_ROLL_WON) item comparison, to auto equip the item won.

https://github.com/blueboy/portal/commit/2474cbf534f499de730fb60e3d39ca9683d77d89

kennumen commented 11 years ago

Technical difficulties aside, I reject your notion that people do not do advanced checks on loot rolls. For a long time you were chastised as a ninja looter (and quickly expelled from the group) if you would roll on items not applicable to you or worse than what you have (exceptions apply - e.g. if a tank likes a DPS gear and nobody else needs it he could roll a need for his solo game). I probably have an addon to help in this but it takes me 5-10 seconds to compare a roll item to my equipped item. The only reason I might do a faulty roll is if someone's looting during the fight.

A warrior would have little use for cloth items, despite being able to equip them. A warrior shouldn't roll need on a great gun/bow just because he can equip it. A warrior shouldn't roll on a +20 int plate helmet. And so on. Need shouldn't be rolled for clearly worse gear. I've never played long with humans who acted like the bots do now on rolls. If you say no, it's no, but I disagree with your opinion on this.

blueboy commented 11 years ago

I stand corrected ;)