blueboy / portal

This portal repo is for development purposes only
http://github.com/blueboy/portal
GNU General Public License v2.0
27 stars 24 forks source link

Random crash #47

Closed HerrTrigger closed 11 years ago

HerrTrigger commented 11 years ago

Report made at:

http://cmangos.net/thread-74-post-737.html#pid737

blueboy commented 11 years ago

Issue #47:

I think I've found the cause of the crash. You said that you had a party of real players and no bots loaded, when it crashes as you try to enter a partychat message. I bet the message included one of these keywords 'help' or 'gm' or 'complete'. Unfortunately I didn't anticipate a situation where the party did no include at least one bot. There was no check in place for the existence of a party bot, so it crashed when it tries to call the playerbot function

This issue has been fixed here: https://github.com/blueboy/portal/commit/a9221514c7a738cb6b6096df69530ce9089466e0 The fix has been tested and we can consider the issue closed