blueboy / portal

This portal repo is for development purposes only
http://github.com/blueboy/portal
GNU General Public License v2.0
27 stars 24 forks source link

Bots not drinking #51

Closed kennumen closed 11 years ago

kennumen commented 11 years ago

Bots are not drinking to regain mana. Easily reproducable case is taking a paladin healer to an instance such as Ragefire Chasm. When told to use [Milk] the milk is used/drank just fine. After that, milk is still not drunk automatically.

Milk is a level 5 item and the bot was level 17 at this point, but I've seen the same problem with other bots (including the Mage of this party).

On a possibly related note, the mage was not creating food or water either.

kennumen commented 11 years ago

Update: Buff() function was returning RETURN_x values while the check in DoNonCombatActions() (for the paladin at least) was expecting a boolean value. So "RETURN_NO_ACTION" was accepted as 'buff done, skip loop' and it never got to the drink/food check.

Now that that's fixed, odd behavior - it will state it's drinking, will not drink (nor use the melon juice), will however wait 25 seconds OOC as expected. Then it sees it's still low on mana (may heal first if it was OOM before 'drinking') and this time WILL drink. As well as state it's drinking and spend another 25 seconds OOC.

To be looked at next time.

kennumen commented 11 years ago

I believe this issue has been resolved.