Bots don't stop buffing themselves

blueboy / portalclassic

playerbot support for C(ontinued)-MaNGOS (classic fork)

GNU General Public License v2.0

18 stars 32 forks source link

Bots don't stop buffing themselves #1

Closed cala closed 11 years ago

cala commented 11 years ago

Bots cast buff on themselves repeatedly until they run out of mana. Examples:

a dwarf priest (lvl 13) casts "Inner fire" on himself until he is out of mana. Then he says "I could use a drink", sits, starts to drink then raises immediatly to continue buffing himself
a dwarf paladin (lvl 14) does exactly the same expect for the buff (I don't know which one he casts on himself).

blueboy commented 11 years ago

Thanks for the feedback ;) As I remember we had a similiar issue on our 'wotlk' code. I'll hunt out the fix we found and port it across.

Cheers

cala commented 11 years ago

Tested with a druid: keeps buffing herself with 'Thorns'. The bug seems to affect only buffs with a duration lesser or equal to 10 min. Long duration buffs (30 min or 1h) are unaffected (it seems so).

cala commented 11 years ago

New addition: yesterday with two bots (the aforementioned paladin and priest), the paladin kept buffing it self as discribed above, while the priest did not. However, the priest did not buff anybody at all while he was correctly casting "Power Word: Fortitude" previously.

My todo list about classic is pretty huge at the moment, but I'll have a look at this later.

blueboy commented 11 years ago

Thanks for the update. This buffing issue might be similar to the buffing issue we had with the warlock class. The warlocks kept trying to buff their minion 'imps', without success. It turned out that the imps have an ability 'Phase Shift', that prevents them from being harmed by spells, but also prevents positive effects. I had to include a condition in the warlock AI to fix this.

I'm fairly busy myself at present, so I do appreciate that you can't be in two places at once. We have plenty to keep us busy, so no worries at present and speak with you later. ;)

cala commented 11 years ago

A quick update. :) The issue is not always repeatable:

sometimes the bot buffs as expected (most of the time)
sometimes it does not buff at all (very rarely)
sometimes it overbuffs itself (always with lox duration buff, I'd say 25% of the time) However, the behavior remains the same for a whole game session. More strangely, two bots of same level, same class may have different buffing behavior.

cala commented 11 years ago

I didn't see this issue in a while, so I suggest to closed it and assume it was "fixed" by one of the last core updates.