search

blueboy / portalclassic

playerbot support for C(ontinued)-MaNGOS (classic fork)
GNU General Public License v2.0
18 stars 32 forks source link

[enhancement] Healing bots do not handle HoT correctly #3

Closed cala closed 8 years ago

cala commented 11 years ago

Priests repeatedly cast "Renew" on a target that is not full life, even if the remaining ticks of the previous "Renew" are not expired.

I have to test , but the issue should be the same with druid bots and their Rejuvenation/Regrowth spells and maybe shaman healing totems.

blueboy commented 11 years ago

I'm embarrassed to say that I'm not sure exactly how 'healing totems' are supposed to work :-o I never have the time to play the game myself :( I know that there has been extensive work done with the bot AI on our 'wotlk' code, particularly with regard to healing. I feel sure the answer to this issue can be found there. Leave it with me.

We have an outstanding issue with our 'R2' code

https://github.com/blueboy/portalR2/issues/2

It would be interesting to know if paladin 'holy shock' is working or not, with the 'classic' code ?

Cheers

cala commented 11 years ago

I'm not sure how healing work either as I almost never played shaman. I'll try it nonetheway as I think totems are not managed by playerbot, but totem casting is. So, if a shaman repeatdly lays healing totem, the issue is probably the same.

I'll also test the "holy shock" spell in classic. Maybe this evening or tomorrow.

cala commented 11 years ago

I wasn't able to reproduce the bug with a druid. Her healing spell casting rotation was quite good in regards of how the players were hurted.

Regarding 'Holy Shock', I can confirm the bug: paladin do not cast the spell on hostile targets. Instead, they cast it on themselves, triggering the healing effect of the spell. (the spell has two effects: a damaging effect when casted on hostile target, a healing effect when casted on allies). If asked to cast it on ally, they do it as expected.

cala commented 11 years ago

As for the "overbuffing" bug, the behavior is not always repeatable. For a few days everything was quite fine while nothing was changed on playerbot code (but core code was updated to last revision). I'll keep you informed. :)

cala commented 11 years ago

After further testing it seems the issue only occurs when Renew is the only healing spell priest bots know (Lesser Heal is not used by the priest AI), thus I guess the AI sees a characters needs healing and bots cast Renew repeatedly as this is their only option. This issue disappears when bots learn "Heal" spell.

This make this issue a "low level" issue.

cala commented 9 years ago

This issue is fixed on the dev branch. I let it open until the dev branch is merged into master.

cala commented 8 years ago

Merged in master branch now.