search

bluecherrydvr / bluecherry-apps

Bluecherry surveillance system (server application)
http://www.bluecherrydvr.com
GNU General Public License v2.0
217 stars 68 forks source link

Bug/654 redirect to stats.php on disconnect #672

Closed JahleelAbraham closed 8 months ago

JahleelAbraham commented 8 months ago

The issue outlined by #654 is caused when the client disconnects from the internet and can no longer send a request to /ajax/stats.php. The code that causes this is a commit made to solve issue #474 which sends the entire browser to the URL /ajax/stats.php/ because the background request failed.

The solution proposed by this PR works around both of these issues by create a way to create exception to the redirection when the request fails by simply passing false to the optional parameter redirectOnFail.

This is by no means a proper solutions and a better solution for both issue #654 and #474 might be needed to be discussed.

andrey-utkin commented 8 months ago

Tested this manually, the fix holds up - leaving the web page to idle for a long time, and deliberately disconnecting machine (shortly, or until requests time out) doesn't cause any redirect. Merging.