search

bluecmd / fortigate_exporter

Prometheus exporter for Fortigate firewalls
GNU General Public License v3.0
232 stars 72 forks source link

feat: Added pba_per_ip return for ippool to differentiate between ippool types #267

Closed 33Fraise33 closed 9 months ago

33Fraise33 commented 9 months ago

Hello,

a while ago I added the ippool probe to the exporter. While using this we noticed that it is hard to see if an ip pool is exhausted if you are mix and matching one-to-one and pba ip pools. Unfortunately the api does not return the ippool type but it does return the amount of pba_per_ip which is 1 for a one-to-one and x for port-block-allocation. This way we can kind of differentiate the types being in use and we can create reasonable alerts: fortigate_ippool_available_ratio < 0.2 and fortigate_ippool_pba_per_ip != 1

Also it seems like overload ippools are not being returned by the API (which I have just noticed now).

bluecmd commented 9 months ago

Can you add it to the README as well? Thanks!

33Fraise33 commented 9 months ago

Can you add it to the README as well? Thanks!

done!

bluecmd commented 9 months ago

:tada: This PR is included in version 1.24.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: