search

bluedenim / log4j-s3-search

Log4j appender with S3, Azure, Google Cloud, and search publishing
MIT License
65 stars 44 forks source link

Thread pool executer shutdown not being called. #120

Closed krishamar91 closed 2 years ago

krishamar91 commented 2 years ago

Hi,

Thread pool shutdown in LoggingEventCache class is not been called during shutdown hook in Log4j2Appender class. This is causing thread leaks and Apache tomcat is not stopping when a stop command is been sent, every time I have to force kill the tomcat process.

Can you please update the shutdown hook to call LoggingEventCache .shutdown()

bluedenim commented 2 years ago

Thanks! I'll look into it. May even help with https://github.com/bluedenim/log4j-s3-search/issues/109

bluedenim commented 2 years ago

Release 3.6.0 should have the fix. Thanks much for the call-out!

krishamar91 commented 2 years ago

Thank You Van.