blueedgetechno / win11React

Windows 11 in React 💻🌈⚡
https://win11.blueedge.me
Creative Commons Zero v1.0 Universal
9.03k stars 927 forks source link

Yashash isn't elgible to be a Code Owner #523

Closed luni-moon closed 2 years ago

luni-moon commented 2 years ago

https://github.com/blueedgetechno/win11React/blob/ac3691ba67911434909214f0ad569969e1e2f784/.github/CODEOWNERS#L4

Currently, he does not have write access to this repo, which means he cannot be a code owner.

win11bot commented 2 years ago

Hey, thank you for creating an issue. We will normally respond within 24 hours.

luni-moon commented 2 years ago

CC. @yashash1511

yashash-pugalia commented 2 years ago

@blueedgetechno shall give me back write access once he comes online

ok so codeowner is used to automatically add someone as a reviewer for a pr.

the directory can be change to use some wildcard format to include the other parts of settings too like the settings.scss, settingsData.json **/apps/**/settings*.* something like this should work ig

image yep exactly how i had like it

andrewstech commented 2 years ago
  |   -- | --   |     |     |     |     |     |     |   |   |   |   |   |   |   |   |   |   |     |     |     |   |     |   |   |   |     |     |   |     |     |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |     |     | Yashash isn't elgible to be a Code Owner · Issue #523 · blueedgetechno/win11React   |     |     |     |     |     |
.427l3.396 3.396a.25.25 0 00.354 0l3.396-3.396A.25.25 0 0011.396 7H4.604a.25.25 0 00-.177.427z">   |   |
  |   |   |   |   |   |   |   |   |   |   |   |     |   |   |   |     |     |
  |
  |     |     |
  |   |

Choose a reason for hiding this comment

  |

The reason will be displayed to describe this comment to others. Learn more.

  |
  |   |   |
  |     |
  |     |   |   |   |   |   |   |   |
  |

blue shall give me back write access once he comes online

  |

ok so codeowner is used to automatically add someone as a reviewer for a pr.

  |

the directory can be change to use some wildcard format to include the other parts of settings too like the settings.scss, settingsData.json
  | **/settings*.* something like this should work ig

  |
  |
  |     |     |
  |     |   |     |
  |
  |     |
  |   |

  |   |   |   |   |

  |   |
  |     |
  |   |     |   |     |     |   |     |     |     |     |     |     |   |
  |
  |   |
  |   |     |     |   |     |     |     |   |
  |
  |
  | @andrewstech   |
  |
  |
  |   |   |
  |   |   |
  |
  |   |   |
  |   |
  |   |
  |     |     |
  |   |   |   |   |     |   |   |   |   |     |   |   |   |   |
  |     |
  |   |   |   |   |     |   |   |   |   |     |   |     |   |     |   |   |   |   |
  |     |
  |   |   |   |   |     |   |   |   |   |     |   |   |   |   |
  |     |
  |     |   |   |   |   |     |   |     |   |   |   |   |     |
  |   |   |   |   |     |   |
  | Select a reply   | ctrl .   |
  |     |   |   |   |   |   |   |     |
  |
  |   |     |     |
  |     |     |
  |   |   |   |   |     |   |   |   |   |     |   |   |   |   |     |   |   |   |   |     |   |   |   |   |     |   |   |   |   |
  |
  |
  |     |   |     |   |
  |   |     |   |     |   |     |   |   |     |
  |
  |   |     |     |   |
  |     |
  |
  |
  |     |
  |
  |
  |
  |   |   |   |   |   |   |
  |
  |     |     |
  |
  |
  |
  |
  |     |
  |
  |     |
  | Remember, contributions to this repository should follow   | its   | contributing guidelines   | and   | code of conduct.   |
  |     |     |   |     |
  |     |     |
  |   |     |   |
  |
  |     |     |     |   |     |     |
  |     |     |     |
  |     |   |   | Labels   |   |     |   |
  | Apply labels to this issue   |   |
  |
  |
  |   |
  |
  |     |     |   |     |
  |
  |     |
  |     |   | bug   |   |   |     |   | less priority   |   |     |   | other   |   |     |
  |     |
  |     |     |     |     |
  |
  |
  |     |   |   | Projects   |   |     |   |
  | Projects   |   |
  |     |     |   |     |
  |
  |     |     |   | None yet   |     |   |     |
  |     |     |   |     |     |   |     |
  |
  |
  |     |
  |     |   |   | Development   |   |     |   |
  | Link a pull request from this repository   |   |
  |     |     |   |     |
  |
  |     |     |     |   | for this issue or link a pull request.   |     |     |     |     |
  |
  |     |     |   |     |
  |     |   |     |     |
  |
  |
  | 4 participants   |
  |   |
  |
  |     |     |     |
  |
  |   |   | Lock conversation   |   |   |
  |
  |   |

  | Lock conversation on this issue   |

  |
  |
  |
      |
  • Other users can’t add new comments to this issue.
  •   |
  •   | You and other collaborators   | with access   | to this repository can still leave comments that others can see.   |
  •   |
  • You can always unlock this issue again in the future.
  •   |
  |     |
  |
  |   |
  |
  |   |

  | Optionally, choose a reason for locking that others can see. Learn more about when   | it’s appropriate to lock conversations.   |

  |
  |
  |
  |   |
  |
  |
  |     |     |
  |
  |   |   |
  |     |     |     |
  |
  |
  |   |   | Transfer issue   |   |   |   |   |   |   |   |   |   |   |
  |
  |
  |     |
  |
  |   |   | Convert to discussion   |   |   |   |
  | Loading convert to discussion form...   |
  |
  |
  |
  |
  |     |     |     |     |
  |     |
  |     |   |   |     |     |   |     |     |   |     |     |   |   |     |   |     |   |     |     |     |     |   |     |   |   |     |   |     |   |     |     |   |     |     |   |

  |     |  

luni-moon commented 2 years ago

wtf, and why does quoting it not work??? @andrewstech

yashash-pugalia commented 2 years ago

Blue added me back :)