bluefireteam / audioplayers

A Flutter package to play multiple audio files simultaneously (Android/iOS/web/Linux/Windows/macOS)
https://pub.dartlang.org/packages/audioplayers
MIT License
2.01k stars 845 forks source link

ci: Publish from GitHub CI #1760

Closed Gustl22 closed 3 months ago

Gustl22 commented 8 months ago

Description

This allows publishing audioplayers from the GitHub CI. The PR creation is available as a workflow dispatch (with option for prerelease) to not overwhelm the PR pipeline.

See: dart-lang/pub-dev#7177

Checklist

Breaking Change

Related Issues

Gustl22 commented 8 months ago

~Indirectly blocked by https://github.com/dart-lang/pub/pull/4145, but we should do this in another PR anyway.~ ~Or we use pubignore: https://stackoverflow.com/questions/69760021/what-should-be-ignored-in-darts-pubignore~ ~Edit: This does not work, as that doesn't change the fact that these files are still checked in in git. So I removed them from git manually.~ Edit: this was fixed

For test the workflow see: https://github.com/Gustl22/audioplayers/actions/runs/8032514104/job/21941993530 And with removing invalid files, passing: https://github.com/Gustl22/audioplayers/actions/runs/8037664053/job/21952740435

We could merge it, but for a release, we may need to do some changes / exclude the audio file with the non ascii char.

Gustl22 commented 8 months ago

uh oh, thank you for the explanation! And thank you for investing time in such a useful feature. Gave my thumbs for issue and PR :D

Gustl22 commented 3 months ago

Example run passes: https://github.com/Gustl22/audioplayers/actions/runs/10339776138

Gustl22 commented 3 months ago

No hurry, I will give it a try in my own package :D