search

bluefishjs / bluefish-archive

A SolidJS diagramming framework
https://bluefishjs.org
MIT License
75 stars 4 forks source link

feat!: Rename Row/Col to StackH/StackV #22

Closed joshpoll closed 1 year ago

joshpoll commented 1 year ago

Closes #18.

Based on user feedback, Row and Col names are confusing b/c they conflict with flexbox's row. HStack and VStack are more agnostic names.

joshpoll commented 1 year ago

Please also try verifying the UI tests! I renamed the stories, which is why there are two changes.

catherinemei commented 1 year ago

Changes look good! I tried approving the UI tests, but it says "Read Only, You must be a reviewer" (see image below) - I'm logged in with my GitHub account though so unclear why it's not recognizing I'm a reviewer for this PR.

Screenshot 2023-10-25 at 11 56 01 AM

Although, maybe UI reviewers and PR reviewers are different? This is what my Manage/Permissions page looks like:

Screenshot 2023-10-25 at 11 58 08 AM
joshpoll commented 1 year ago

sorry for thrashing. we should probably discuss this syntax change in person as there are a couple of options:

I think StackX and StackY feels too close to Observable Plot transforms. StackV and StackH have better autocomplete behavior than VStack and HStack b/c you can start typing Stack and get both options. Also I would argue readability is better b/c of the position of the camel casing. The downside is that it's closer syntactically to Observable Plot and further syntactically from SwiftUI without matching either of them, which might be confusing to remembe if you're moving back and forth between tools.