bluefishjs / bluefish-archive

A SolidJS diagramming framework
https://bluefishjs.org
MIT License
75 stars 4 forks source link

Fix weird line.tsx behaviour #68

Closed vezwork closed 7 months ago

vezwork commented 7 months ago

Thank you so much @gracefh for merging QCLine and PulleyLine into a single component.

This PR fixes a bug/weird-behaviour that comes from QCLine.

Here's the weird behaviour: image

Here's after the fix (blue color to show that the line starts and ends and box boundaries and does not go to their centers): image

vezwork commented 7 months ago

Tested the diagrams that use Line and they are working in my local storybook!

image image image
joshpoll commented 7 months ago

These changes mostly look good to me. I noticed a few discrepancies with the papers in the diagram though:

There are also some regressions on interactivity and scenegraph debug mode, but those should be fine for now. We will have to fix post deadline.

gracefh commented 7 months ago

I'll work on the example discrepancies! Thanks so much for getting the fix done @vezwork