search

bluefoxr / COINr

COINr
https://bluefoxr.github.io/COINr/
Other
22 stars 7 forks source link

Distance to target #12

Closed bluefoxr closed 7 months ago

bluefoxr commented 1 year ago

Enable distance to target to work using coin targets. Also possibly add two-ended targets.

chloebellamyFR commented 1 year ago

Hi Will, I'm trying to run distance to target, on a coin, but getting an error "Error in stopifnot(is.numeric(x), is.numeric(targ), length(targ) == 1, : argument "targ" is missing, with no default" I have added the Target column to iMeta, but it doesn't seem to have copied over to my coin when I built it. Is this the issue that this bug refers to please? Thanks!

bluefoxr commented 1 year ago

Hi, which version of COINr are you using? There have been some recent fixes to address this issue, so if you didn't already, please install the latest dev version:

# Install development version from GitHub
devtools::install_github("bluefoxr/COINr")

Then try following the examples here: https://bluefoxr.github.io/COINr/articles/normalise.html#use-of-targets

If the problem persists please send me the command you are running and the data needed to run the command, e.g. your coin and the exact command, so I can reproduce the error. Thanks!

chloebellamyFR commented 1 year ago

Hi Will,

Thanks so much for the quick response! I’ll try the dev version and will let you know if issues persist.

Cheers!

Best wishes,

Chloe

@.**@.>

Normal work pattern: Tuesday - Friday, 09:00 - 17:00

From: Will Becker @.> Sent: 29 September 2022 10:29 To: bluefoxr/COINr @.> Cc: Chloe Bellamy @.>; Comment @.> Subject: Re: [bluefoxr/COINr] Distance to target (Issue #12)

Hi, which version of COINr are you using? There have been some recent fixes to address this issue, so if you didn't already, please install the latest dev version:

Install development version from GitHub

devtools::install_github("bluefoxr/COINr")

Then try following the examples here: https://bluefoxr.github.io/COINr/articles/normalise.html#use-of-targets

If the problem persists please send me the command you are running and the data needed to run the command, e.g. your coin and the exact command, so I can reproduce the error. Thanks!

— Reply to this email directly, view it on GitHubhttps://github.com/bluefoxr/COINr/issues/12#issuecomment-1262017635, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATVD72AQJF2WQQI5L7EHEGTWAVOPPANCNFSM54LLLTWA. You are receiving this because you commented.Message ID: @.***>

bluefoxr commented 7 months ago

Hi just clearing up old issues - please note in the latest version of COINr there is more flexibility for targets and other normalisation parameters stored in iMeta: see https://bluefoxr.github.io/COINr/articles/normalise.html#goalposts-targets-and-imeta-specification

Closing this issue now.