khufkens commented 1 year ago

@eliocamp from testing it seems that the downloaded files remain persistent in the CDS request queue. I was looking through the service but couldn't find an explicit delete statement to purge any data request from the CDS queue (as in old wf_delete(). Where does this live now?

codecov-commenter commented 1 year ago

Codecov Report

Merging #109 (30fae5a) into master (1907288) will increase coverage by 2.63%. The diff coverage is 0.00%.

:exclamation: Current head 30fae5a differs from pull request most recent head 0e88ffe. Consider uploading reports for the commit 0e88ffe to get more accurate results

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   12.84%   15.47%   +2.63%     
==========================================
  Files          19       20       +1     
  Lines         911      937      +26     
==========================================
+ Hits          117      145      +28     
+ Misses        794      792       -2

Impacted Files	Coverage Δ
R/service-cds-workflow.R	`0.00% <0.00%> (ø)`
R/service-cds.R	`0.00% <0.00%> (ø)`
R/wf_request.R	`0.00% <0.00%> (ø)`
R/wf_transfer.R	`0.00% <ø> (ø)`
R/zzz.R	`32.48% <0.00%> (+6.46%)`	:arrow_up:
R/wf_get_key.R	`20.00% <0.00%> (-15.00%)`	:arrow_down:
R/wf_set_key.R	`26.08% <0.00%> (+26.08%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eliocamp commented 1 year ago

Huh. It seems that I didn't port the deletion logic to the new classes. I'll have to do it :P

bluegreen-labs / ecmwfr

adding docs + test data + function references #109

Codecov Report