bluegreen-labs / ecmwfr

Interface to the public ECMWF API Web Services
https://bluegreen-labs.github.io/ecmwfr/
Other
106 stars 30 forks source link

Incorrect `filename` displayed in message with `wf_request_batch()` #150

Closed Rafnuss closed 1 month ago

Rafnuss commented 1 month ago

Sorry, didn't take the time to make a reprex, let me know if you need one.

But it seems like the filename accounts for the path argument while it shouldn't, right?

>  ecmwfr::wf_request_batch(
+     request_list[include_stap_id]
+     path = directory
+   )
Requesting data to the cds service with username ecmwfr
- staging data transfer at url endpoint or request id:
  bed5bb94-624f-42b0-98e9-0893a84f31e3

  on server: https://cds-beta.climate.copernicus.eu/api

- Your request has been submitted as a CDS request.

  Even after exiting your request is still beeing processed!

- Retry downloading as soon as completed! 

  If you close your session use the following code: 

  wf_transfer(
   url = 'https://cds-beta.climate.copernicus.eu/api/retrieve/v1/jobs/bed5bb94-624f-42b0-98e9-0893a84f31e3',
   path = './data/wind/18LX',
   filename = './data/wind/18LX/18LX_1.nc'
  )

- Delete the job upon completion using:
  wf_delete(
   url ='https://cds-beta.climate.copernicus.eu/api/retrieve/v1/jobs/bed5bb94-624f-42b0-98e9-0893a84f31e3'
  )

  If your session stays open you can donwload or delete requests using: 

  file$download() and file$delete() *

 [* with file from: file <- wf_request(request)] 

I'm expecting to get:

  wf_transfer(
   url = 'https://cds-beta.climate.copernicus.eu/api/retrieve/v1/jobs/bed5bb94-624f-42b0-98e9-0893a84f31e3',
   path = './data/wind/18LX',
   filename = '18LX_1.nc' # and not ./data/wind/18LX/18LX_1.nc'
  )
khufkens commented 1 month ago

A fix is provided in the latest github version, please patch and pull when possible.