[A-398] User Feedback - Githubissues

bluehalo / mean2-starter

Other

4 stars 0 forks source link

[A-398] User Feedback #138

Closed ymao1 closed 7 years ago

ymao1 commented 7 years ago

This contains the A-390 branch as well, so merge that first!

Adds a new 'Give Feedback' dropdown menu item under the help menu that pops up a modal, allowing users to enter their feedback. This is sent to whatever contactEmail is specified in the config. There is also a Feedback tab on the admin page that lists all the feedback received.

brianghig commented 7 years ago

@ymao1 from some testing that @GKingsbury was doing, it looks like the permissions are setup as:

anyone can submit feedback
only admins can export feedback to CSV
admin-only (non-auditor) cannot view the feedback through the UI (e.g., on the Admin > Feedback page)
only auditors can view feedback (with paging in the UI)
auditor-only (non-admin) cannot export the feedback to CSV

Is that the intention of the capabilities? Should admins also be able to view feedback through the UI without having the "auditor" role? Also, should auditors be able to export the feedback to CSV?

ymao1 commented 7 years ago

The intention was that admins should be able to view feedback through the UI and export to CSV. Auditors shouldn't have access. I will fix this. Good catch!

ymao1 commented 7 years ago

@brianghig @GKingsbury, I pushed a fix for this bug. It came down to the fact that we aren't storing user feedback in its own collection, just as part of the audit records, so the permissions were a little muddy. I could also modify to store feedback in its own collection if you feel like that's necessary.