Commented "<reference path" affecting build

[antonioscuri]

> ✘ [ERROR] TS6053: File '/builds/pec/sentinela/sentinela-web/node_modules/@bluehalo/ngx-leaflet-draw/lib/core/leaflet-draw.directive.ngtypecheck.d.ts' not found. [plugin angular-compiler]
>     node_modules/@bluehalo/ngx-leaflet-draw/lib/core/leaflet-draw.directive.d.ts:1:21:
>       1 │ /// <reference path="leaflet-draw.directive.ngtypecheck.d.ts" />
>         ╵                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ✘ [ERROR] TS6053: File '/builds/pec/sentinela/sentinela-web/node_modules/@bluehalo/ngx-leaflet-draw/lib/leaflet-draw.module.ngtypecheck.d.ts' not found. [plugin angular-compiler]
>     node_modules/@bluehalo/ngx-leaflet-draw/lib/leaflet-draw.module.d.ts:1:21:
>       1 │ /// <reference path="leaflet-draw.module.ngtypecheck.d.ts" />
>         ╵                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ✘ [ERROR] TS6053: File '/builds/pec/sentinela/sentinela-web/node_modules/@bluehalo/ngx-leaflet-draw/public-api.ngtypecheck.d.ts' not found. [plugin angular-compiler]
>     node_modules/@bluehalo/ngx-leaflet-draw/public-api.d.ts:1:21:
>       1 │ /// <reference path="public-api.ngtypecheck.d.ts" />

After removing the 3 lines starting in "/// <reference path" from the ts, the build succeeded.

Using version 18.0.3

[morong34]

same error here

Versions: "@angular/core": "^18.1.1" "@bluehalo/ngx-leaflet": "^18.0.2", "@bluehalo/ngx-leaflet-draw": "^18.0.3",

[reblace]

See https://github.com/angular/angular/issues/56945

[antonioscuri]

I updated everything in package.json, including Typescript version. Still the same problem. We have a very large project with many dependencies, why just ngx-leaflet-draw has the problem? Again, by just removing those lines everything compiles and run perfectly.

[reblace]

AFAICT, the library needs to be built using TS 5.5 to fix the issue. I'm working on that now.

[antonioscuri]

Ok Thanks a lot!

Em qua., 24 de jul. de 2024, 11:26, Ryan Blace @.***> escreveu:

AFAICT, the library needs to be built using TS 5.5 to fix the issue. I'm working on that now.

— Reply to this email directly, view it on GitHub https://github.com/bluehalo/ngx-leaflet-draw/issues/153#issuecomment-2248138380, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6UZ67PWYNP4DEIACBO5I3ZN62R7AVCNFSM6AAAAABLLFWQUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYGEZTQMZYGA . You are receiving this because you authored the thread.Message ID: @.***>

[reblace]

I confirmed the /// <reference path="leaflet-draw.directive.ngtypecheck.d.ts" /> lines are gone. Can you test quick and see if it resolved the issue with v18.0.4?

[antonioscuri]

In about an hour. Thanks

Em qua., 24 de jul. de 2024, 11:37, Ryan Blace @.***> escreveu:

I confirmed the /// <reference path="leaflet-draw.directive.ngtypecheck.d.ts" /> lines are gone. Can you test quick and see if it resolved the issue with v18.0.4?

— Reply to this email directly, view it on GitHub https://github.com/bluehalo/ngx-leaflet-draw/issues/153#issuecomment-2248180742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6UZ66JP7Y2Q5XHUHZKEPTZN63ZVAVCNFSM6AAAAABLLFWQUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYGE4DANZUGI . You are receiving this because you authored the thread.Message ID: @.***>

[antonioscuri]

I confirm that it is now working. Tested on local environment and in the CI. Thanks again!