bluehalo / ngx-leaflet

Core Leaflet package for Angular.io
MIT License
774 stars 127 forks source link

Ivy - Not compiling #228

Closed marct83 closed 5 years ago

marct83 commented 5 years ago

Before submitting an issue, please verify the following:

If this is a request for help, please use Stack Overflow and use the ngx-leaflet tag, or review the Getting Help section of the README. We watch the ngx-leaflet tag on Stack Overflow and will respond there. We will no longer be responding to help and 'how-to' requests on GitHub.

If this is a bug, issue, enhancement request, etc. verify the following before submitting your issue:

I'm using:

angular 8.0.0 leaflet 1.5.1 ngx-leaflet 5.0.2

When trying to compile with Ivy enabled I am getting the following error and it fails to compile:

ERROR in There is no typings path for LeafletLayerDirective in /home/tremm1/code/interfaces/node_modules/@asymmetrik/ngx-leaflet/dist/leaflet/layers/leaflet-layer.directive.js.

We need to add an export for this class to a .d.ts typings file because Angular compiler needs to be able to reference this class in compiled code, such as templates. The simplest fix for this is to ensure that this class is exported from the package's entry-point.

hlovdal commented 5 years ago

Duplicate: #227 - Not compatible with Ivy Compiler.

reblace commented 5 years ago

Closing as duplicate. See #227