search

bluehalo / ngx-leaflet

Core Leaflet package for Angular.io
MIT License
767 stars 126 forks source link

Support for Angular 14 #335

Closed SvenAtGit closed 2 years ago

SvenAtGit commented 2 years ago

After upgrading my amgular project to version 14 i get an error on npm update

npm ERR! Found: @angular/common@14.0.1 npm ERR! node_modules/@angular/common npm ERR! @angular/common@"^14.0.1" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @angular/common@"13" from @asymmetrik/ngx-leaflet@13.0.2 npm ERR! node_modules/@asymmetrik/ngx-leaflet npm ERR! @asymmetrik/ngx-leaflet@"^13.0.2" from the root project

uap-universe commented 2 years ago

A change of these lines would be required:

https://github.com/Asymmetrik/ngx-leaflet/blob/93d7958670ebbd5d8a70fc191a6aa1813aceff64/projects/ngx-leaflet/package.json#L14-L15

Atgoogat commented 2 years ago

I've submitted a PR https://github.com/Asymmetrik/ngx-leaflet/pull/336.

A2Ple98 commented 2 years ago

I hope someone with write access notices this PR, this is really important for new projects. Maybe there should be more people with write access

SvenAtGit commented 2 years ago

Yes this is an important one! I am still waiting to upgrade my project to Angular 14 because of this issue, this is the only item that is blocking the upgrade for one of my projects.

A2Ple98 commented 2 years ago

Maybe the solution is to fork the repo until they see this at @Asymmetrik

uap-universe commented 2 years ago

Maybe one of @andrewmarcus @brianghig @jrassa @luan-dev @rstjohn can prevent that yet another fork is born.

luan-dev commented 2 years ago

I will look at this soon

reblace commented 2 years ago

Working on it now...

reblace commented 2 years ago

Just published v14. Ping this thread if you have any issues w/it.

reblace commented 2 years ago

Closing, but will monitor in case anyone has issues w/v14