bluehalo / ngx-leaflet

Core Leaflet package for Angular.io
MIT License
767 stars 126 forks source link

Address production readiness / production build optimization in the Readme #354

Closed neuged closed 1 year ago

neuged commented 1 year ago

As someone who is evaluating how to integrate mapping into an existing production app, I think it would be great to have a few words in the readme on whether this is used in production and can be built with --prod.

There is at least one open ticket and a somewhat recent blog post which both suggest that builds with --prod produce buggy results and you need to use ng build --optimization=false or set “buildOptimizer”: false in angular.json, which for many production ready apps is decidedly not an option.

That makes me somewhat weary if in choosing this module, we would not have to switch away from leaflet and/or this module later, because some features will not be usable without build optimization.

So as a suggestion: If this module is used in production and generally supports build optimization, it would be reassuring to have that in the readme. Or in contrast, if this module should not be used with build optimization that would be very useful to know as well.

neuged commented 1 year ago

This seems to be less of a problem than I thought. The linked post is older than I had in mind and the open ticket has its own story/is a fixabble issue, so it is probably better to close this. Sorry for the confusion!