bluehalo / nifi-nar-bundles

Apache License 2.0
13 stars 0 forks source link

Nifi 1.15.2 updates #100

Closed Dreichard38 closed 2 years ago

Dreichard38 commented 2 years ago

I had to make some changes to the NAR files to get them to build for NiFi version 1.15.2, the only safe version of NiFi to run at this point(thanks Log4J). Below I'll list all the changes that I made, along with justifications:

Changes:

  1. Removed an unnecessary session.commit() from AutoTerminator.java because that's done automatically at the end of execution of onTrigger, and session.commit() is deprecated.
  2. Replaced session.commit() in FetchFileSplits.java with session.commitAsync(callback) because session.commit() is deprecated. This is easily the largest change in this PR, and I've never used that processor before, so it most likely needs verification.
  3. Several instances of replacing org.apache.nifi.util.StringUtils with org.apache.commons.lang3.StringUtils since the former has been removed, and we include apache commons anyways
  4. The SSLContextService.ClientAuth enum has been moved to its own file, so there's some changes removing the SSLContextService prefix to references of that enum
  5. PropertyDescriptor.expressionLanguageSupported(boolean) is finally deprecated now, so there's a couple of changes for that
  6. Since the minimum NiFi version was increased here but the readme hadn't been updated since NiFi version 1.3, I added templating to the README.md file. Now the versions get updated after every build, using maven variables for the template values. I've also committed the output of that templating as the new README.md.