search

bluehalo / node-fhir-server-core

An Open Source secure REST implementation for the HL7 FHIR Specification. For API documentation, please see https://github.com/Asymmetrik/node-fhir-server-core/wiki.
https://asymmetrik.com/healthcare
MIT License
391 stars 120 forks source link

fixed ServerError so it works in typescript projects #179

Closed jjosef closed 5 years ago

jjosef commented 5 years ago

This is a simple fix which makes the prototype on the error class work with typescript projects.

Robert-W commented 5 years ago

Hey @jjosef, thanks for submitting this. Sorry for taking a little to get back to you. We are trying to finalize many things (including my presentation) for next weeks conference. I'll ask the team to review this since I am not very familiar with TS and we'll try to get this taken care as soon as we can.

Robert-W commented 5 years ago

Hey @jjosef, so I just got back from dev days and starting merging all the PR's, apparently one of them has created conflicts with this PR (looks like maybe some sort of whitespace issue or something). Could you possibly update this(sorry about that).

Also, our typescript guy wanted me to ask what the issue you were having was as he said what's in the error should not cause any issue (what version of TS are you all running)?

jjosef commented 5 years ago

Hey Robert,

I'm using the latest version of typescript and it would not compile without the change I made.

On Fri, Jun 14, 2019 at 8:45 AM Robert notifications@github.com wrote:

Hey @jjosef https://github.com/jjosef, so I just got back from dev days and starting merging all the PR's, apparently one of them has created conflicts with this PR (looks like maybe some sort of whitespace issue or something). Could you possibly update this(sorry about that).

Also, our typescript guy wanted me to ask what the issue you were having was as he said what's in the error should not cause any issue (what version of TS are you all running)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Asymmetrik/node-fhir-server-core/pull/179?email_source=notifications&email_token=AABPRPXNMJGIX7Q4OMMMYMTP2OOFXA5CNFSM4HREXZ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXW2UYQ#issuecomment-502114914, or mute the thread https://github.com/notifications/unsubscribe-auth/AABPRPSZGIHV2ZKEAGTGVOLP2OOFXANCNFSM4HREXZ7A .

-- John Josef 407.617.4975

Robert-W commented 5 years ago

@jjosef, Hmm ok, we can't seem to recreate the issue on our side but I don't want to hold up your development I can go ahed and merge this anyway.