search

bluehalo / node-fhir-server-core

An Open Source secure REST implementation for the HL7 FHIR Specification. For API documentation, please see https://github.com/Asymmetrik/node-fhir-server-core/wiki.
https://asymmetrik.com/healthcare
MIT License
393 stars 122 forks source link

fix: authenticationMiddleware config #183

Closed peturv closed 5 years ago

peturv commented 5 years ago

Fixed issue where configuration passed to authenticationMiddleware could not be accessed properly

Robert-W commented 5 years ago

Hi @peturv, this looks good and thanks for adding tests. It looks like we also messed up the authenticationMiddleware on line 119 in src/server/router.js, could you apply your fix their as well?

peturv commented 5 years ago

Hi @peturv, this looks good and thanks for adding tests. It looks like we also messed up the authenticationMiddleware on line 119 in src/server/router.js, could you apply your fix their as well?

No problems.

Missed that call, think those two should be it though. (did a free-text search for references to authenticationMiddleware before committing this time).

Robert-W commented 5 years ago

Yea same here, that's the only other one I saw. thanks. Ill merge this once the CI is done!!

Robert-W commented 5 years ago

Im getting the rest of the PR's done today as well, so I'm hoping to deploy an update later this afternoon