search

bluehalo / node-fhir-server-core

An Open Source secure REST implementation for the HL7 FHIR Specification. For API documentation, please see https://github.com/Asymmetrik/node-fhir-server-core/wiki.
https://asymmetrik.com/healthcare
MIT License
391 stars 120 forks source link

fix(ssl): minor code change #209

Closed keerthivasan-r closed 4 years ago

keerthivasan-r commented 4 years ago

There was a minor code fix in the SSL config setup

fixes issue #208

zeevo commented 4 years ago

It seems like this change got made already in the form of server.ssl being checked as the first clause in the boolean expression. If I am mistaken please open another issue.

keerthivasan-r commented 4 years ago

Hmm,then. I think i didn't tell it clearly. In the below script, the value of USE_HTTPS gets the value of server.ssl.cert instead of server.ssl. That creates the problem, when it is used by helmet config

this.env = {
IS_PRODUCTION: !process.env.NODE_ENV || process.env.NODE_ENV === 'production',
USE_HTTPS: server.ssl && server.ssl.key && server.ssl.cert,
};

Hope you get my point now!