Closed mgramigna closed 2 years ago
@luan-asym do you have any knowledge on who I could contact to potentially review this and #300 ? Just trying to figure out if this codebase is still actively maintained
@luan-asym do you have any knowledge on who I could contact to potentially review this and #300 ? Just trying to figure out if this codebase is still actively maintained
Hi there! The codebase is still being maintained, but we are running behind on updates. I will look into this PR and give you an update as soon as I can.
Thanks! :)
Thanks for the quick feedback @ekoon121! I believe I resolved all the outstanding comments regarding the testing logic
@mgramigna I got our code gen up and running with the 4.0.1 changes. It looks really similar to your code so I just added to this branch. Take another look and I'll merge the changes after we get some input from some other devs
EDIT: here is the commit with the changes between 4.0.0 and 4.0.1 https://github.com/Asymmetrik/node-fhir-server-core/commit/f9c38c6d20275464595a1b95cd8d9fb27f60acbe
@luan-dev Thanks!! The changes look reasonable to me. Thanks for looping them in on this branch.
What codegen are you folks using for these schemas?
@mgramigna It is a proprietary software that we created internally. We may be updating it to work with R4B
@luan-dev ah, cool. Well thanks for giving this another look! Let me know if there's anything I can do to move it forward more, but sounds like your team has got it from here.
See #239, FHIR 4.0.1 is crucial to support the new interoperability rule.
The official changelog for this version is here
The only changes I saw that seemed necessary for this framework are updating the parameters:
The paths are updated in the parameters for
SubstanceSpecification
andStructureDefinition
I just pulled over the old 4_0_0 schemas to a 4_0_1 directory with the parameter changes made. Ideally the 4_0_0 ones could just be re-used since they don't change, but this way is backwards compatible and won't break servers using
4_0_0
.I also updated tests and defaults to use 4_0_1 where applicable