search

bluehost / endurance-page-cache

Other
25 stars 12 forks source link

Adding optional parameter #22

Closed bassplayer7 closed 6 years ago

bassplayer7 commented 7 years ago

PHP was throwing a warning, I believe, because the second argument was required, but not (always?) passed in. My solution on a friend's site was to just add = false there, but the argument is not used anyway, so I'm not sure what good it is doing in there exactly to begin with.

acjmckay93 commented 7 years ago

This seems to be the same issue i have, what are the implications of these changes, will they be overridden by any updates. and am i technically allowed to do this.

acjmckay93 commented 7 years ago

well this works for anyone with the same issue

MikeHansenMe commented 7 years ago

The second paragraph in the comment method ( approved ) needs to have a default status. I will get this added.

On Jun 18, 2017 11:04 AM, "acjmckay93" notifications@github.com wrote:

This seems to be the same issue i have, what are the implications of these changes, will they be overridden by any updates. and am i technically allowed to do this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bluehost/endurance-page-cache/pull/22#issuecomment-309264200, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYzpAe8sn4swHzsLTIBlj_rLKj-amTpks5sFOBngaJpZM4N1-kR .

bassplayer7 commented 7 years ago

@MikeHansenMe thanks for getting that resolved. I'm curious - does BlueHost automatically push those updates out to client sites?

MikeHansenMe commented 7 years ago

Yea, anything over version 0.7 will get updated when we do new releases.

On Jun 19, 2017 3:22 PM, "Jesse Maxwell" notifications@github.com wrote:

@MikeHansenMe https://github.com/mikehansenme thanks for getting that resolved. I'm curious - does BlueHost automatically push those updates out to client sites?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bluehost/endurance-page-cache/pull/22#issuecomment-309577519, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYzpMV5P5UtwIPs4_5Jwh0XRglK40b5ks5sFuaPgaJpZM4N1-kR .

bassplayer7 commented 6 years ago

This has been fixed: https://github.com/bluehost/endurance-page-cache/blob/master/endurance-page-cache.php#L168