search

bluehost / endurance-page-cache

Other
24 stars 11 forks source link

PHP notice error #29

Closed rsg-ndilworth closed 6 years ago

rsg-ndilworth commented 6 years ago

[22-Nov-2017 15:45:47 UTC] PHP Notice: Undefined variable: new_expirations in wp-content/mu-plugins/endurance-page-cache.php on line 641

MikeHansenMe commented 6 years ago

Looking at the code it, it looks like the reason that may be possible is if the value of the dropdown was edited on the settings page. We will get a default set in the switch case that will set the $new_expiration variable. That should remove the chances of this notice. Thank you for reporting it.

bkjproductions commented 6 years ago

Has this been resolved yet? Noticing it over at a Bluehost site.

MikeHansenMe commented 6 years ago

Looks like the change was never made. I will get it updated on the repo today.

MikeHansenMe commented 6 years ago

Here is the PR: https://github.com/bluehost/endurance-page-cache/pull/44 we will get that in asap but wanted to share in case you wanted to apply it before.

bkjproductions commented 6 years ago

Hi Mike, Thanks! --Brian

At 8:29 AM -0700 10/18/18, Mike Hansen wrote:

Here is the PR: https://github.com/bluehost/endurance-page-cache/pull/44#44 we will get that in asap but wanted to share in case you wanted to apply it before.

- You are receiving this because you commented. Reply to this email directly, https://github.com/bluehost/endurance-page-cache/issues/29#issuecomment-431054283view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AEVycWLLiQ8dxgjJJSQVgf-Z0fRGxe1Sks5umJ5QgaJpZM4QnyTbmute the thread.

-- BKJ Productions, LLC 781-662-8800

214 Commercial Street #200 Malden, MA 02148

http://www.bkjproductions.com | info@bkjproductions.com

Celebrating over 25 years in business!

MikeHansenMe commented 6 years ago

No problem. Not sure what happened but thank you for bringing it back up.