Fixes for for latest SS4 and PHP 7.1

bluehousegroup / silverstripe-pardot

BSD 3-Clause "New" or "Revised" License

4 stars 5 forks source link

Fixes for for latest SS4 and PHP 7.1 #14

Closed sminnee closed 5 years ago

sminnee commented 5 years ago

Rolling this out to a pre-release silverstripe.com on SS 4.3 and PHP 7.1, we've noticed some issues, which are resolved in this PR.

PS: we'd be happy to assist with the maintenance of this module if you wanted to add me as a committer?

andrewvt commented 5 years ago

@sminnee I added you to the repository with write access. Thanks for the help keeping this module up to date.

sminnee commented 5 years ago

Appreciate it, @andrewvt! Are you happy for me to merge this PR and tag a 2.0.0-beta1 release?

andrewvt commented 5 years ago

Yes, that would be great. Since you guys are doing all the heavy lifting at the moment please take the lead on PRs and tag/release creation as you see fit. I'll just monitor activity so I know what's going on. Thanks again.