search

blueimp / Gallery

blueimp Gallery is a touch-enabled, responsive and customizable image & video gallery, carousel and lightbox, optimized for both mobile and desktop web browsers. It features swipe, mouse and keyboard navigation, transition effects, slideshow functionality, fullscreen support and on-demand content loading.
https://blueimp.github.io/Gallery/
Other
3.75k stars 984 forks source link

Vimeo video not working in the Carousel video gallery #272

Open danielsian opened 1 year ago

danielsian commented 1 year ago

https://blueimp.github.io/Gallery/

KN1GHT - Last Moon video won't start doesn't matter the browser.

Is this a bug?

sebastian-marinescu commented 1 year ago

Hi @danielsian,

I can see @blueimp is still using the old library: https://github.com/blueimp/Gallery/blob/master/js/blueimp-gallery-vimeo.js#L65

And this seems to be deprecated: https://github.com/vimeo/player.js#migrate-from-froogaloop https://github.com/vimeo/player.js/blob/master/docs/migrate-from-froogaloop.md

I can see a PR for this #271 and another fork also handling it https://github.com/blueimp/Gallery/compare/master...mediataivas:Gallery:master

So you either take one of the two forks, or you wait until the PR is tested and merged.

sebastian-marinescu commented 1 year ago

Also, this seems to be a duplicate of #268