KDE Konsole does not respect the current working directory when executing x-terminal-emulator (edited)

blueimp / atom-open-terminal-here

Open the Terminal (Mac OS X, Linux) or Command Prompt (Windows) in the given directory via context menu or keyboard shortcut in the Atom text editor.

https://atom.io/packages/open-terminal-here

MIT License

47 stars 20 forks source link

KDE Konsole does not respect the current working directory when executing x-terminal-emulator (edited) #13

Open fcojgodoy opened 7 years ago

fcojgodoy commented 7 years ago

Open the terminal in the user folder (no the indicated folder) when a terminal window is already open.

blueimp commented 7 years ago

Hi @fcojgodoy, could you explain your use case a little further? What's the purpose of opening up the terminal in the user folder via this extension in contrast to simply opening the terminal, which should use the user folder as default directory?

fcojgodoy commented 7 years ago

Sorry, point to point:

I have a terminal opened.
I open Atom, do right click over a folder in tree view and click on "Open terminal here"
A terminal is open on /home/user

The behaviour is correct just when:

Any terminal is open.
I open Atom, do right click over a folder in tree view and click on "Open terminal here".
A terminal is open in the right folder.

Kubuntu 16.10 Konsole 16.04.3 Atom 1.10.2

blueimp commented 7 years ago

Ah, sorry I misunderstood you there. Thanks for the bug report and the environment info, I'll look into it.

blueimp commented 7 years ago

Could you please execute the following in a shell (if possible not Konsole, but another desktop shell):

cd /tmp
x-terminal-emulator

Could you report back what happens in the two instances you described, once with Konsole open and once without Konsole open.

The command above (x-terminal-emulator) is exactly what get's executed on Linux by this atom package, with the given directory as context.

fcojgodoy commented 7 years ago

Case 1:

Konsole is open
In Qterminal I execute cd /tmp and x-terminal-emulator
Konsole is open in /tmp

Case 2:

Konsole is close
In Qterminal I execute cd /tmp and x-terminal-emulator
Konsole is open in /tmp

Case 3:

In Open-terminal-here settings change the command for 'qterminal'
All is OK. When qterminal is open and when it not, the opened folder is the correct!

Then, the problem is in Konsole?

(I'm sorry for my English. If you do not understand something ask it without problems)

blueimp commented 7 years ago

Thanks for testing this @fcojgodoy.

And yes, unfortunately it looks like this is an issue with Konsole, seems like it ignores the context directory when already opened.

fcojgodoy commented 7 years ago

Ok, thank you. I'll ask the guys at Konsole.