search

blueimp / atom-open-terminal-here

Open the Terminal (Mac OS X, Linux) or Command Prompt (Windows) in the given directory via context menu or keyboard shortcut in the Atom text editor.
https://atom.io/packages/open-terminal-here
MIT License
47 stars 20 forks source link

Should default to opening PowerShell on Windows 10 instead of CMD.exe #17

Open Peteous opened 7 years ago

Peteous commented 7 years ago

On Windows 10, the OS suggests/prefers that you use PowerShell as a replacement for CMD.exe. This package, however, only opens CMD.exe, even if you have Windows set up to open PowerShell instead of CMD.exe. It would be great if you could fix this.

It would also be great if you could give the option to open the new Bash on Ubuntu on Windows shell that is available in Windows 10.

blueimp commented 7 years ago

Thanks for your report, @Peteous As a quick fix, in the open-terminal-here settings, you can set the Command to a different one than the default start /D "%cd%" cmd.

Long term, we should modify the platform specific switch for the default command and check the Windows version. Since testing on Windows is a little more involving for me, I'm looking forward to any pull request. :)

yanakey commented 6 years ago

I've just replaced cmd with the path to Git Bash in .atom\packages\open-terminal-here\index.coffee

    # defaultCommand = 'start /D "%cd%" cmd'
    defaultCommand = 'start /D "%cd%" D:\\Soft\\DEV\\Git\\bin\\sh.exe --login -i'

and it works. But it really would be great to have an option for that.

Anyway thanks for plugin! Now work in Atom become even more enjoyable (-:

youngjuning commented 6 years ago

@yanakey That‘s cool