search

blueimp / aws-smtp-relay

SMTP server to relay emails via Amazon SES or Amazon Pinpoint using IAM roles.
MIT License
75 stars 34 forks source link

Support for ConfigurationSetName #2

Closed fubarhouse closed 5 years ago

fubarhouse commented 5 years ago

This PR resolves #1.

It introduces the ability to pass in a value for ConfigurationSetName which would otherwise be a default value (empty/""). The field has also been added to tests already supported by the application.

Testing will be organized prior to removing the draft flag, but I would appreciate some feedback from @blueimp in regards to how receptive they are to merging this and what they would like to see included in this PR leading up to a merge.

Also, for general knowledge, this field is natively supported by the API.

fubarhouse commented 5 years ago

Marked as ready based on advice.

tobybellwood commented 5 years ago

Thanks @fubarhouse - I've tested and can confirm we can view metrics in CloudWatch and SES contents via Kinesis Firehose.

Note that to use the -r switch, we just overrode the entrypoint in Openshift.