search

blueimp / nightwatch

This project is deprecated in favor of blueimp/wdio.
https://github.com/blueimp/wdio
134 stars 43 forks source link

Increase Timeout && Later Node Version #11

Closed StephenMayeux closed 7 years ago

StephenMayeux commented 7 years ago

Great Dockerfile, and thanks for putting this together! The example works like a charm and it was easy to port to my project. But I was wondering if you could increase the timeout in wait-for.sh from 10 seconds to 60 seconds? My app container is a React application that must be bundled into a production build before getting served by my Express server (unlike in the example that uses an nginx image that serves /app/index.html), and this process can take between 20-40 seconds.

And also, the nightwatch container installs via apk nodejs-lts, but I am using some ES6 features in my tests that are not supported by Node LTS. Maybe this is not possible though as I could not find a later version of Node in the apk directory.

Thanks again!

StephenMayeux commented 7 years ago

Should have read the comments in wait-for.sh. 

 The default timeout of 10 seconds can be changed via `-t timeout` argument.