search

blueimpact / kucipong

BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Slimdown store templates #160

Closed arowM closed 7 years ago

arowM commented 7 years ago

This PR slims down template files related to Kucipong.Handler.Store. It might be better to redirect to 404 page if store data is Nothing. @cdepillabout , which do you think is better to redirect to 404 page, or show "no store" message on normal page as it is?

cdepillabout commented 7 years ago

I think a 404 page makes more sense. It's easier for us to write, and I think most net users are used to 404 pages.

For example, if you go to a Twitter page of a user who doesn't exist, it returns a 404 page:

https://twitter.com/eafasehfasuef

I think it would be fine for our service to return a 404 page for stores that do not exist.

cdepillabout commented 7 years ago

This looks good. I'll create a new issue to redirect to a 404 page.

arowM commented 7 years ago

It makes sense! Thank you.