blueimpact / kucipong

BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Do we want to follow Post-Redirect-Get? #44

Open cdepillabout opened 8 years ago

cdepillabout commented 8 years ago

Do we want to follow the Post-Redirect-Get design pattern?

It looks like PR #42 (https://github.com/blueimpact/kucipong/pull/42/files#diff-f84a648380f9d597ebfd8de3de10fb22R67) returns an html page from a POST handler instead of a redirect.

In order to both (1) follow the Post-Redirect-Get pattern, and (2) send info/error messages back to the user, we would need some sort of messaging system like used in Yesod:

http://www.yesodweb.com/book/sessions#sessions_messages https://hackage.haskell.org/package/yesod-core-1.4.24/docs/Yesod-Core-Handler.html#g:21

Post-Redirect-Get Pros:

Post-Redirect-Get Cons:

@arowM What do you think?

arowM commented 8 years ago

@cdepillabout From the view point of a project manager of this project, I do not propose to introduce Post-Redirect-Get design pattern with extra costs.

However it's also good choice to use this design pattern because we can contribute to the web development flow using Haskell, and of course it seems to be interesting. The Yesod is good framework but it is monolithic and less freedom to choose any library we want. We should provide alternative way to construct a web system with particular purpose libraries.

How do you feel if we set this issue as low priority and solve this after whole system works well with conventional design?

cdepillabout commented 8 years ago

How do you feel if we set this issue as low priority and solve this after whole system works well with conventional design?

That sounds good to me!