search

blueintegral / WaitOrWalk

The information you really want when waiting at the bus stop: is it quicker to wait or to walk? Only works for Georgia Tech right now.
9 stars 3 forks source link

Weather Underground API key no longer required? #26

Closed Tanner closed 11 years ago

Tanner commented 11 years ago

I noticed that server.py no longer dies if the Wunderground API key is not yet/non-existent. It seems the change was implemented in merge commit 1de2f5933ae49ebae7bdeadf984981fe194a340b.

I separated the key into the config.ini to a) separate the key from being hardcoded, and b) be able to detect when the key is not available.

When I created the pull request I made the decision to not allow the server to run when missing the API key. It seemed logical to me as weather is apart of the service and was merged in with no contest.

If we don't want to require the API key, I'm ok with that, but at least print out some sort of message when the server is started and not just saying nothing.

darkzeroman commented 11 years ago

Sorry, I didn't feel like registering for one and had to suppress that error message.

I had forgotten to add the message, it is added now.

blueintegral commented 11 years ago

Yep, I just merged #27 that prints out a warning if there's no API key.

darkzeroman commented 11 years ago

Hey Tanner, I just wanted to say sorry if I broke a feature. It kinda sounded like you were a bit mad about that no error message for weather API key.

I code for this in between my school assignments and classes and could probably be more thorough like I would be for a real product.

But it's fun. We're moving things fast, coding, shipping, breaking at times, repeat.

I agree we could probably use more in depth code reviews, but this is a fun side project for us. I'm using it as a way to learn more Python which I recently picked up.