search

bluek8s / kubedirector

Kubernetes Director (aka KubeDirector) for deploying and managing stateful applications on Kubernetes
Apache License 2.0
399 stars 90 forks source link

Ezml 1127 check app difference #602

Closed Kosta91 closed 2 years ago

Kosta91 commented 2 years ago

Resolves https://github.com/bluek8s/kubedirector/issues/591

joel-bluedata commented 2 years ago

Looks neat! I just had a couple of suggestions about comment tweaks there.

One thing that occurred to me: it will be annoying if the new kdapp has some list elements (like for example the roles) that are the same as the old kdapp, but in a different order. That is functionally identical but we will detect it as a difference. I think it would probably be too much work to account for that situation -- which I believe shouldn't come up much if at all in reality -- so it's probably just something we'll document.