search

bluek8s / kubedirector

Kubernetes Director (aka KubeDirector) for deploying and managing stateful applications on Kubernetes
Apache License 2.0
399 stars 90 forks source link

rsync progress field #621

Closed Kosta91 closed 2 years ago

joel-bluedata commented 2 years ago

Thought of one more thing. How does this code behave when the image doesn't have rsync, i.e. when it is using cp to do the copy and the progress file does not exist?

(It looks like probably it will fail gracefully but even so I'd rather that it not add error messages to the KD log in that case.)

Kosta91 commented 2 years ago

Thought of one more thing. How does this code behave when the image doesn't have rsync, i.e. when it is using cp to do the copy and the progress file does not exist?

(It looks like probably it will fail gracefully but even so I'd rather that it not add error messages to the KD log in that case.)

Well, I added the checking if rsync is present at the container calling rsync --version. If it is not present, the error will be not raised or logged