bluekitchen / btstack

Dual-mode Bluetooth stack, with small memory footprint.
http://bluekitchen-gmbh.com
Other
1.74k stars 618 forks source link

Add new parse firmware method for REALTEK cards using new signature, such as 8822eu #446

Closed zhuqing-realsil closed 1 year ago

zhuqing-realsil commented 1 year ago
  1. update lmp subversion and project id information
  2. add firmware patch parse method for cards using new signature, such as 8822eu
  3. modify the method to get fw project id from firmware patch
  4. add new element 'chip_type' in struct 'patch_info' to get max patch size allowed to be downloaded for different card types
  5. add check fw procedure to judge whether firmware already exists or not before download patch procedure
  6. add roll over procedure for index when it reaches 0x80, i.e, 0,1,2,3,...,126,127(7f),1,2,3,...
mringwal commented 1 year ago

Wow, that's a large patch! Thanks for all the work you've put into this.

We'll need to go over the changes in detail. E.g. you've used the linux kernel list implementation, which is (probably) licensed under GPL, which we cannot use with our stack, as we need to keep it under BSD license. We will replace it with our linked list implementation. Similarly, we have functions to read 32 bit values from unaligned memory, we will us them as well.

Also, given that this could be considered intellectual property from Realtek, we'd like to make sure that you're from Realtek (or it's Realsil subsidiary) and that we are allowed to distribute the new code to our customers.

Could you ask your manager please to get in contact with me via matthias@bluekitchen-gmbh.com to discuss this and other potential collaborations? e.g. we'd love to get some dev kit of your newest offerings, especially LE Audio.

Cheers, Matthias

zhuqing-realsil commented 1 year ago

Dear Matthias Ringwald:

I'm from Realsil, a subsidiary of Realtek. As the Chinese Spring Festival is coming, all the employees of our company will have a holiday in the next two weeks, and I will also have a holiday from tomorrow. If you don't mind, I will discuss these changes with you further after my vacation.

Best regards

Zhu Qing 发件人: Matthias Ringwald @.> 发送时间: 2023年1月17日 17:26 收件人: bluekitchen/btstack @.> 抄送: 庆祝 @.>; Author @.> 主题: Re: [bluekitchen/btstack] Add new parse firmware method for REALTEK cards using new signature, such as 8822eu (PR #446)

Wow, that's a large patch! Thanks for all the work you've put into this.

We'll need to go over the changes in detail. E.g. you've used the linux kernel list implementation, which is (probably) licensed under GPL, which we cannot use with our stack, as we need to keep it under BSD license. We will replace it with our linked list implementation. Similarly, we have functions to read 32 bit values from unaligned memory, we will us them as well.

Also, given that this could be considered intellectual property from Realtek, we'd like to make sure that you're from Realtek (or it's Realsil subsidiary) and that we are allowed to distribute the new code to our customers.

Could you ask your manager please to get in contact with me via @.**@.> to discuss this and other potential collaborations? e.g. we'd love to get some dev kit of your newest offerings, especially LE Audio.

Cheers, Matthias

— Reply to this email directly, view it on GitHubhttps://github.com/bluekitchen/btstack/pull/446#issuecomment-1385083813, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5DKOT7XXHHZ5QNMHZQC2N3WSZQSDANCNFSM6AAAAAATZB7F2U. You are receiving this because you authored the thread.Message ID: @.**@.>>

------Please consider the environment before printing this e-mail.

mringwal commented 1 year ago

Thanks for the quick response. No hurry, we wish you health, wealth, and good fortune for the Chinese New Year! Have a relaxing time.

zhuqing-realsil commented 1 year ago

Thanks for the quick response. No hurry, we wish you health, wealth, and good fortune for the Chinese New Year! Have a relaxing time.

Thank you for your blessing. The code submitted this time still has some problems with support for 8822eu cards and needs to be further modified. Therefore, the code optimization you mentioned can not be carried out for the time being, and we will submit it again after further improvement.

zhuqing-realsil commented 1 year ago

Thanks for the quick response. No hurry, we wish you health, wealth, and good fortune for the Chinese New Year! Have a relaxing time.

Hi. We have modified the code to support 8822eu card and created a new request.