bluekitchen / btstack

Dual-mode Bluetooth stack, with small memory footprint.
http://bluekitchen-gmbh.com
Other
1.74k stars 613 forks source link

compiler warning: btstack-develop with ESP-IDF "master" toolchain #555

Closed ricardoquesada closed 10 months ago

ricardoquesada commented 10 months ago

I'm getting this compiler error using btstack develop branch with ESP-IDF "master" branch.

Compiled on macOS.

Problem is when "warning" are treated as "errors", like in my case.

/src/mesh/adv_bearer.c.obj -c /Users/ricardoq/progs/bluepad32/src/components/btstack/src/mesh/adv_bearer.c
/Users/ricardoq/progs/bluepad32/src/components/btstack/src/mesh/adv_bearer.c: In function 'adv_bearer_advertisements_set_params':
/Users/ricardoq/progs/bluepad32/src/components/btstack/src/mesh/adv_bearer.c:392:11: error: array subscript 'unsigned char[6][0]' is partly outside array bounds of 'uint8_t[4]' {aka 'unsigned char[4]'} [-Werror=array-bounds=]
  392 |     (void)memcpy(gap_direct_address, &direct_address, 6);
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ricardoq/progs/bluepad32/src/components/btstack/src/mesh/adv_bearer.c:383:43: note: object 'direct_address' of size 4
  383 |     uint8_t direct_address_typ, bd_addr_t direct_address, uint8_t channel_map, uint8_t filter_policy){
      |                                 ~~~~~~~~~~^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
mringwal commented 10 months ago

Thanks for reporting. That's not just a warning, that's incorrect. Fixed on develop 5f1af52